Hi, El mar., 21 ene. 2020 a las 8:05, Christian Couder (<christian.couder@xxxxxxxxx>) escribió: > > On Mon, Jan 20, 2020 at 11:23 PM Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > On Mon, 20 Jan 2020, Miriam Rubio wrote: > > > > @@ -777,14 +777,14 @@ static void handle_bad_merge_base(void) > > > "between %s and [%s].\n"), > > > bad_hex, term_bad, term_good, bad_hex, good_hex); > > > } > > > - exit(3); > > > + return -3; > > > > ... which is: what does `3` stand for? > > Maybe the question should have been answered by adding a comment to > the previous patch that added the `exit(3)` statement. > > So yeah we could here add a separate patch that just adds such a comment. > > Or maybe we can add such a comment in this patch and say something > like "while at it let's explain a bit the '3' error code" in the > commit message. I like most your first option because we explain the code in the patch where it is added, but the second one is also ok for me :). Thanks. Best, Miriam
