Hi Dscho, On Mon, Jan 20, 2020 at 10:43 PM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > On Mon, 20 Jan 2020, Miriam Rubio wrote: > > [1/29] bisect--helper: convert `vocab_*` char pointers to char arrays > > > > * New patch to convert `vocab_bad` and `vocab_good` char pointers > > to char arrays > > 29 patches is _a lot_ to review. I would have preferred a series of > smaller patch series. Yeah, it's possible to split it into smaller patch series. There are a many similar patches in the series so it was easier to work on everything together to make similar and consistent changes to all the patches at once. > For example, the first three patches would have made for a fine "some > cleanups" patch series, from my point of view. Yeah, but this might then be rejected by Junio as it would be only "code churn". > Also, as the mail's subject says "part 1", it would be good to have an > overview how this part fits into the overall story of converting `git > bisect` into a built-in. We don't know how the rest will be split yet. Hopefully there will be only one other smaller patch series after this one. > Finally, it would be nice to have a link to a public repository with the > branch from which these mails were generated. Yeah, I agree that would be nice. > I will try to review this patch series in its entirety, but it will take > me a while. Great, thanks! Christian.
