On Thu, Jan 9, 2020 at 9:18 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Han-Wen Nienhuys <hanwen@xxxxxxxxxx> writes: > > > Hi folks, > > > > I have some alpha-quality code for Reftable support in Git at > > > > https://github.com/hanwen/git/tree/reftable > > > > I'd be curious for some feedback, both on the library > > (https://github.com/google/reftable) and the glue code in Git. > > If you are asking for feedback, sendign it over to this list with > [RFC PATCH n/3] as the subject prefix would have better chance. Thanks, I'll look into that when I am done with my current TODO list. In the meantime, I've updated the code at the above URL. The major missing item is currently reflogs; hopefully I'll get to that next week. I asked around, and it looks like we have slight preference for the BSD license (https://developers.google.com/open-source/licenses/bsd). According to the FSF, this is OK to combine with GPL software, so would you be OK with that license? thanks, > I have a feeling that the patch to show-ref is done at the wrong > level. The show_ref() function is given as the callback function > to head_ref() and for_each_ref(), and the way these functions call > the callback function is part of the ref API. "In the reftable > format, ... are stored in the reference database too," is perfectly > fine (that is the implementation detail of the ref API backend) but > "and are produced when iterating over the refs" is not. Hide that > inside the ref API backend you are writing for reftable and this > change will become unnecessary. The API is a little surprising here, because it means that an iterator should always dereference a symref, regardless of storage format. Since it is not specific to the ref backend, this behavior should not be in the ref backend code. But I've modified it now, and it seems to work. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
