> So the gist of the change is to split REPO into two, LOCAL and > WORKTREE. > > If we can find a way to state that concisely, perhaps we can improve > "refine enum" and make it more informative. > Should I just say "split repo scope" Or is that too on the nose? > > diff --git a/t/helper/test-config.c b/t/helper/test-config.c > > index 214003d5b2..6695e463eb 100644 > > --- a/t/helper/test-config.c > > +++ b/t/helper/test-config.c > > @@ -44,8 +44,10 @@ static const char *scope_name(enum config_scope scope) > > return "system"; > > case CONFIG_SCOPE_GLOBAL: > > return "global"; > > - case CONFIG_SCOPE_REPO: > > + case CONFIG_SCOPE_LOCAL: > > return "repo"; > > + case CONFIG_SCOPE_WORKTREE: > > + return "worktree"; > > case CONFIG_SCOPE_CMDLINE: > > return "cmdline"; > > default: > > diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh > > index 7b4e1a63eb..535b2a73f7 100755 > > --- a/t/t1308-config-set.sh > > +++ b/t/t1308-config-set.sh > > @@ -265,7 +265,7 @@ test_expect_success 'iteration shows correct origins' ' > > value=from-cmdline > > origin=command line > > name= > > - scope=cmdline > > + scope=command > > Why??? I meant to put this change into the next series in the patch, but I must have messed up, so I'll readjust that. -- Matthew Rogers
