Jeff King <peff@xxxxxxxx> writes: > Recent versions of the gcc and clang Address Sanitizer produce test > failures related to regexec(). This triggers with gcc-10 and clang-8 > (but not gcc-9 nor clang-7). Running: > > make CC=gcc-10 SANITIZE=address test > > results in failures in t4018, t3206, and t4062. > ... > We can work around that by having the preprocessor replace regexec with > git_regexec (both in the callers and in the actual implementation), and > we truly end up with a call to our custom regex code, even when > compiling with ASan. That's probably a good thing to do anyway, as it > means anybody looking at the symbols later (e.g., in a debugger) would > have a better indication of which function is which. So we'll do the > same for the other common regex functions (even though just regexec() is > enough to fix this ASan problem). > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > Makefile | 3 +++ > compat/regex/regex.h | 5 +++++ > 2 files changed, 8 insertions(+) I guess we should treat this the same way as the recent vcproj "fix" by Dscho, i.e. fast-track to 'maint' to ensure that all public integration branches has it soonish? Thanks.
