Re: [PATCH v3 15/15] rebase: change the default backend from "am" to "merge"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> Why?  "Commands which create no more than one commit (git-commit,
> git-merge, maybe single-commit git-revert or git-cherry-pick) call
> post-commit, commands which create several commits derived from others
> (git-am, git-rebase, git-cherry-pick, sometimes git-revert ) call
> post-rewrite instead for performance reasons"

Sounds totally wrong.  post-rewrite is about carrying forward data
that used to be associated with commit X to new commit Y when Y was
created by "rewriting" X (i.e. after Y gets created X no longer has
any purpose other than as a historical curiosity).  There is nothing
"for performance reasons" here.  There should be nothing for "git
revert" to do with post-rewrite (because the resulting commit is not
even a rewrite of the commit that was reverted), and "git
cherry-pick" is not even a rewrite operation (it is to duplicate an
existing commit into another unrelated context, without discarding
the original commit).

I am a bit confused...



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux