On Fri, Jan 10, 2020 at 10:05:47AM -0500, Eyal Soha wrote: > Signed-off-by: Eyal Soha <shawarmakarma@xxxxxxxxx> Some rationale might be helpful for people who find this commit later (especially if it ends up being a regression for people with 256-color support but not 16-color). Maybe: This results in shorter output, and is _probably_ more portable. There is at least one environment (GitHub Actions) which supports 16-color mode but not 256-color mode. It's possible there are environments which go the other way, but it seems unlikely. > color.c | 7 ++++++- > t/t4026-color.sh | 4 ++++ The code itself looks good. We don't currently document the magic of 0-7, so we don't need to change the documentation there (though perhaps we ought to). -Peff
