On Tue, Jan 14, 2020 at 04:32:12PM +0000, Elijah Newren via GitGitGadget wrote: > When I was more than a bit burned out on dir.c in late December, I had > looked at making another change to remove the need for a dirent but > punted because it looked like "way too much work". Junio and Peff both > later suggested the same cleanup, but I said it was too much work. Peff > posted a patch which demonstrated that it was actually pretty simple[1], > but I somehow read his email wrong and assumed he was commenting on my > patch (if I had looked even slightly closer...). His patch was actually > for before en/fill-directory-fixes was applied, so I have updated it > slightly to apply after that series. Yeah, I hadn't really grokked your patch, so I was hoping you'd build your stuff on top. :) > I'm not sure if I'm supposed to add a Reviewed-by me or a Signed-off-by > or both, but I read through it closely to avoid any hidden surprises. I > probably could have saved Dscho some time last month if I would have > just looked a little closer. Sorry about all that... > > (And yeah, we'll need Peff's Signed-off-by, since I'm leaving him as the > author; I really only made a small tweak to update his patch.) > > CC: Jeff King peff@xxxxxxxx [peff@xxxxxxxx], Johannes Schindelin > Johannes.Schindelin@xxxxxx [Johannes.Schindelin@xxxxxx] Hmm, looks like you maybe meant for more headers (and cc's) to happen than did. Anyway, I'm certainly fine with this direction, and you have my: Signed-off-by: Jeff King <peff@xxxxxxxx> -Peff
