On 1/14/2020 2:34 PM, Taylor Blau wrote: > Hi Stolee, > > On Tue, Jan 14, 2020 at 07:25:54PM +0000, Derrick Stolee via GitGitGadget wrote: >> This series is based on ds/sparse-list-in-cone-mode. >> >> This series attempts to clean up some rough edges in the sparse-checkout >> feature, especially around the cone mode. >> >> Unfortunately, after the v2.25.0 release, we noticed an issue with the "git >> clone --sparse" option when using a URL instead of a local path. This is >> fixed and properly tested here. > > I haven't had a chance to look at the other patches (besides the one > that I have already reviewed on- and off-list), so take my comments here > with a grain of salt. > > It's too bad that 'git clone --sparse' isn't working with URLs in > v2.25.0, but it happens, and I don't think that this is a grave-enough > issue to warrant a new release. At least, since '--sparse' is new in > v2.25.0, we're not breaking existing workflows that have already relied > on it. > > And, since sparse-checkout is still relatively niche (at, least for now > ;-)), I think that this not handling cloning from URLs is fine until > v2.26.0. Since we've already worked out the workaround to be: git clone --no-checkout <url> <dir> cd <dir> git sparse-checkout init --cone there is no rush to fix this. Users _may_ discover the --sparse option from the clone docs and complain, but we can point them to the above directions for now. > Of course, if there's ever another need for v2.25.1, I don't think that > this would *hurt* to release then, which is to say that we definitely > should have these patches in a release, soon, but I don't think that > there's a terrible sense of urgency in the meantime. I wouldn't complain to have patches 1-3 in an otherwise-warranted .1 release. Thanks, -Stolee
