On 2020-01-13 at 13:53:12, Eric Sunshine wrote:
> On Mon, Jan 13, 2020 at 7:41 AM brian m. carlson
> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
> > diff --git a/t/t5703-upload-pack-ref-in-want.sh b/t/t5703-upload-pack-ref-in-want.sh
> > @@ -19,7 +19,7 @@ get_actual_commits () {
> > git verify-pack -v o.idx >objs &&
> > - grep commit objs | cut -c-40 | sort >actual_commits
> > + grep commit objs | cut -d" " -f1 | sort >actual_commits
> > }
> > @@ -37,6 +37,7 @@ check_output () {
> > test_expect_success 'setup repository' '
> > + test_oid_init &&
> > test_commit a &&
>
> I think this `test_oid_init` is supposed to be introduced in patch
> 21/24, not here in 20/24 for which it serves no purpose.
You're right. I'll just squash them together, since they don't really
make sense being separate.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Attachment:
signature.asc
Description: PGP signature
