On Mon, Jan 6, 2020 at 11:53 PM Denton Liu <liu.denton@xxxxxxxxx> wrote: > Changes since v1: > * Clean up as suggested by Eric > * Replace 12/16 with J6t's patch In the future, please also provide a link in the mailing list archive to the previous round (v1 [1], in this case) to help reviewers understand what these bullet points mean since the points themselves are quite lacking in detail. Pointing people at the previous round helps not only those who reviewed that round -- who may have already forgotten the details of their own and others' review comments -- but will also help onboard people who start reviewing at this round. > Range-diff against v1: > -: ---------- > 3: 501eb147c3 t2018: improve style of if-statement > 16: 31aa0c7d15 < -: ---------- t4124: let sed open its own files Dropping patches when re-rolling is fine, but please do not sneak in new patches unrelated to any of the original changes in this series. Not only is it likely that such a patch will get overlooked by reviewers, but even when it is noticed, reviewers have to spend extra time and effort trying to understand why the patch was added in the first place (especially since there is not even a mention of it in the cover letter). After digging into it, I can see that this newly-added patch (3/16) is an additional sensible style cleanup to the same test script that many of the other patches are touching, so in some sense one could argue that it's very vaguely related to v1, but please keep in mind the potentially negative effect it can have on reviewers[2] when new changes are added to a series, causing the series to diverge rather than converge. [1]: https://lore.kernel.org/git/cover.1577454401.git.liu.denton@xxxxxxxxx/ [2]: https://lore.kernel.org/git/CAPig+cQqK-HiDjmnBFo-qeE6cZ73EveWg6Ygb-4BX3X_iPSJZA@xxxxxxxxxxxxxx/
