On Fri, Jan 10, 2020 at 01:59:30AM +0000, Derrick Stolee via GitGitGadget wrote: > Here is a very small fix to the cone-mode pattern-matching in > unpack-trees.c. Johannes found this while running a Coverity scan for > other issues. He alerted me to the problem and I could immediately see > my error here. In creating this patch, most of my time was spent asking > "how did this work before?" and "why didn't this hurt performance?" > Hopefully my commit message explains this thoroughly enough. Yes, it makes perfect sense (and as soon as I saw the explanation of the problem, my immediate response was also "wait, how did this even work"). And the patch itself looks good. > As for making it into the release, I don't know. The change is small, it > has a very limited scope, but this flaw is also not really hurting > anything in a major way. I could go either way. This counts as something small and obvious enough that I'd consider slipping it in at the last minute if it were fixing a bad bug. But given how minor the bug is, being conservative makes sense to me, if only because it's good to exercise our release discipline muscles. :) -Peff
