Junio C Hamano <gitster@xxxxxxxxx> writes: > "Bradford Smith" <bradford.carl.smith@xxxxxxxxx> writes: > >> FWIW, I have successfully run 'make test' and also verified that it >> behaves as I expect with my ~/.gitconfig symlink (in conjunction with >> the my other patch for resolving symlinks). > > Existing "make test" testsuite is not an appropriate thing to > say this patch is safe, as we do not have much symlinking in the > test git repository there. Care to add a new test or two? How about this? On top of your "lockfile to keep symlink" and "set-multivar to use lockfile protocol" patches. --- t/t1300-repo-config.sh | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index 1c43cc3..187ca2d 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -595,4 +595,19 @@ echo >>result test_expect_success '--null --get-regexp' 'cmp result expect' +test_expect_success 'symlinked configuration' ' + + ln -s notyet myconfig && + GIT_CONFIG=myconfig git config test.frotz nitfol && + test -h myconfig && + test -f notyet && + test "z$(GIT_CONFIG=notyet git config test.frotz)" = znitfol && + GIT_CONFIG=myconfig git config test.xyzzy rezrov && + test -h myconfig && + test -f notyet && + test "z$(GIT_CONFIG=notyet git config test.frotz)" = znitfol && + test "z$(GIT_CONFIG=notyet git config test.xyzzy)" = zrezrov + +' + test_done - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
