[PATCH 0/2] Graph horizontal fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This depends on ds/graph-assert-fix.

This is a non-critical (not needed for v2.25.0) response to the previous
discussions [1] [2].

While working to resolve the fix for the assert() bug, I noticed this
regression when multiple edges wanted to collapse with horizontal lines. It
takes a reasonably large graph, but real projects are likely to demonstrate
this behavior.

I arranged the series into two patches: 1. the (failing) test, and 2. the
fix.

The fix commit includes some details about why the change to compress merge
commits caused this regression, and why I feel relatively confident that
this is a correct resolution.

Thanks, -Stolee

[1] 
https://lore.kernel.org/git/faa954fa-ccb9-b034-a39d-d2f0696826ea@xxxxxxxxx/T/#t
[2] 
https://lore.kernel.org/git/xmqqk1635gwu.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/T/#t

Derrick Stolee (2):
  graph: add test to demonstrate horizontal line bug
  graph: fix collapse of multiple edges

 graph.c                      | 10 ++++--
 t/t4215-log-skewed-merges.sh | 62 ++++++++++++++++++++++++++++++++++++
 2 files changed, 70 insertions(+), 2 deletions(-)


base-commit: aa2121af50498c7ea9d5c4c87f9dc66605bf772b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-518%2Fderrickstolee%2Fgraph-horizontal-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-518/derrickstolee/graph-horizontal-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/518
-- 
gitgitgadget



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux