On Wed, Jan 8, 2020 at 5:35 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Heba Waly <heba.waly@xxxxxxxxx> writes: > > > On Fri, Jan 3, 2020 at 11:48 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> > >> Junio C Hamano <gitster@xxxxxxxxx> writes: > >> > > That's a valid suggestion, I can investigate that in a new patch, I'd rather > > keep this one as simple as calling the existing advise function. > > Yeah, the side note wasn't even a suggestion for improving _this_ > topic, nor even specifically addressed to you. Let's stay focused. > Sending out this patch, not only do I want the community's say in using advise() in add.c but using it in general in more locations where hints are displayed using printf() or any other similar function. So when you pointed out that it's not supposed to be used without checking the corresponding configuration variable, I had a similar thought to yours, that it can be improved. Accordingly I might be interested in looking in to this once I finish what I have in hand. Thanks, Heba
