I try to take a closer look at your changes tomorrow evening. Here
are just two short things I saw while taking a short look at the
patch.
Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
> +const char *get_git_work_tree(void)
> +{
> + static int initialized = 0;
> + if (!initialized) {
> + work_tree = getenv(GIT_WORK_TREE_ENVIRONMENT);
> + if (!work_tree) {
> + work_tree = git_work_tree_cfg;
> + if (work_tree && !is_absolute_path(work_tree))
> + work_tree = git_path(work_tree);
A tab is missing here.
> - fprintf(stderr, "No directory given for --work-tree.\n" );
> + error("No directory given for --work-tree.\n");
There should probably be no '\n' at the end when the 'error' function
is used. There are two other calls to fprintf(stderr, <error message>)
next to the one you changed, why did you change this one but not the
other ones?
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
