On Thu, Dec 26, 2019 at 09:21:36AM -0500, Derrick Stolee wrote: > Here are some recommendations (to Garima) for how to proceed with these > patches. Please let me know if anyone disagrees. > > > [1/3]: commit-graph: examine changed-path objects in pack order > > This one is best kept as its own patch, as it shows a clear reason why > we want to do the sort-by-position. It would also be a complicated > patch to include this logic along with the first use of > compute_bloom_filters(). Yeah, I'd agree this one could be a separate patch. It does need more work, though (as you found out, it does not cover --reachable at all). The position counter also probably ought to be an unsigned (or even a uint32_t, which we usually consider a maximum bound for number of objects). -Peff
