Hi,
On Wed, 25 Jul 2007, Junio C Hamano wrote:
> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> > +/* strip out .. and . */
> > +char *normalize_path(char *path)
> > +{
>
> This always makes one worry what should happen when foo/../bar
> is _not_ bar in reality (i.e. foo is symlink to a directory
> elsewhere).
>
> It depends on what kind of "path" you feed to the function (and
> its caller, make_absolute_path()). If you always feed a path
> >from the index (or a path obtained by recursively reading a
> tree), it is Ok. If it is arbitrary path obtained from the user
> or the filesystem, it is not.
Agree. Maybe a comment above the function, like
/*
* The function normalize_path() converts ".." and "." names in
* the given path so that "foo/../bar/./" will come out as "bar".
*
* Note: normalize_path() does not follow symlinks, so if "foo" is
* a symlink in the example above, the result will not work as
* expected.
*/
Hmm?
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
