On Thu, Dec 26, 2019 at 12:49 PM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > When in cone mode, "git sparse-checkout set" takes a list of folders and > constructs an ordered list of patterns for the sparse-checkout file. The > "git sparse-checkout list" subcommand outputs the contents of the > sparse-checkout file in a very basic way. > > This patch changes the behavior of "git sparse-checkout list" when > core.sparseCheckoutCone=true. It will output the folders that were used in > "git sparse-checkout set" to create the patterns, instead of the patterns > themselves. > > I believe this was requested in the initial review, but I cannot find that > message now. Yeah, I think I mentioned it, but couldn't remember for sure. Just did a little digging and found https://lore.kernel.org/git/CABPp-BH13XbNR3MQKE7cHO5e=pMY7kLtGhkX1SQg_o9it=uUug@xxxxxxxxxxxxxx/: "Should the list mode in cone mode be modified to just show the directories the user added? It seems a little weird to show the internal details of the implementation (all the parent directories and negated entries and whatnot). That's also not in a form that users can pass along to future `sparse-checkout add` invocations." Though I then went into other tangents, which may have been what caused it to be forgotten or overlooked. > I was going to include this as part of a longer follow-up series, but I > think this may be worth considering for the 2.25.0 release. Hence, it is > included by itself. Yeah, I think this is a good and small fixup to a new feature in 2.25.0, so it'd be nice if it could be included. Not sure if it's too late given that we're at -rc0, but here's a thumbs up from me if it makes any difference.
