Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Just like assigning a nonempty value, assigning an empty value to a > shell variable when calling a function produces non-portable behavior: > in some shells, the assignment lasts for the duration of the function > invocation, and in others, it persists after the function returns. > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > --- > If it would be useful for me to send a copy of the "Enable protocol v2 > by default" series rebased on top of this, let me know. When rebased, t5552 passes (including the test lint) at the "request v0 explicitly for some tests" step now. The tip of "promote proto v2 to default" series fails at 5552.5 with or without these two patches, though.