On 12/23/2019 7:58 PM, Jonathan Nieder wrote: > Hi, > > The Git users at $DAYJOB have been using protocol v2 as a default for > ~1.5 years now and others have been also reporting good experiences > with it, so it seems like a good time to propose bumping the default > version. It produces a significant performance improvement when > fetching from repositories with many refs, such as > https://chromium.googlesource.com/chromium/src. The benefits of protocol v2 are very clear, assuming the server supports it. And I'm pretty sure there is no downside, as a v0 server continues responding to the v2 request without any extra round trips to agree on protocol. > This only affects the client, not the server. (The server already > defaults to supporting protocol v2.) > > This could go in 2.25 (most of the "next" population is likely already > using protocol.version=2, so the -rc period would be one of the better > ways to expand the user population using this) or could cook in "next" > for a cycle. Either is fine by me. I have no firm opinion on when this lands. The code change is much simpler than I would have thought, and perhaps we had enough testing of the protocol by experts. This series looks good to me. Thanks, -Stolee
