> On 23/12/2019, at 6:48 AM, brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: > > On 2019-12-22 at 00:06:47, Eric Sunshine wrote: >>> On Sat, Dec 21, 2019 at 2:52 PM brian m. carlson >>> <sandals@xxxxxxxxxxxxxxxxxxxx> wrote: >>> This test corrupts various locations in a multi-pack index to test >>> various error responses. However, these offsets differ between SHA-1 >>> indexes and SHA-256 indexes due to differences in object length. Use >>> test_oid to look up the correct offsets based on the algorithm. >>> --- >> >> Missing sign-off. > > Will fix. In the odd case that no reroll is necessary, I'll include it > here: > > Signed-off-by: brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx> You have a fan for your work! This is the hard work. I missed adding sign-off in my patch series also. Fixed in the branch mentioned in the email I sent to the list, about alternative SHA algorithms. I can review this patch series if you like. I’ve applied them in my local tree and run tests. Nothing blew up... Happy holidays.
