Re: [PATCH v2 0/1] [Outreachy] commit: display advice hints when commit fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 20, 2019 at 8:45 AM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> That is exactly the point.  I am not in the business of spoon
> feeding answers.

Why would pointing out a typo clearly to the author be considered as
spoon feeding answers?
Rather than simply reviewing and pointing out mistakes in a clear and
a respectful way?

> I want my contributors to *think*.

Nobody is against *thinking*, and I'm sure an author who found an
issue and implemented a fix
had his/her share of thinking to get the job done.
So I hope a typo is not standing in the way of acknowledging the
author's effort.

> Any contributor working on this topic should be competent enough to
> realize/notice it once it is pointed out---even though lack of
> proof-reading before sending may cause such a mistake by
> carelessness.

I have no reason not to believe that this is crossing the line.
No matter how much a reviewer disagrees with the proposed changes, I'd
appreciate
keeping a mutually respectful discussion during the review process.

Heba



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux