Philip, >The commit message doesn't fully highlight that the config list will >often be all the users config values, so each value will be >disambiguated/identified as to it's origin. I don't really understand what you mean by "it's origin" here. When you say origin, do you mean in the "--show-origin" sense of "file/blob/etc." or something else? Because scope is kind of an orthogonal concept to origin in that sense as you can have files with different origins but the same scope. Thanks, Matt On Thu, Dec 19, 2019 at 12:56 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > <mattr94@xxxxxxxxx> writes: > > >>These are correct changes, but is unrelated noise in the context of > >>the theme of the patch, no? > > > > I think that's the case, would the recommended course of action be to > > move these changes into its own commit? > > > > Yup, and it generally is a good idea to make such a clean-up patch > either early in the series, or as a standalone patch (with a note > under three-dash lines that another topic is coming on top of the > cleanup), because it would be much less likely to introduce new bugs > and can be merged quicly to 'next' and then to 'master' to serve as > a base to build your other changes on top. > -- Matthew Rogers
