Re: [PATCH 08/15] t0020: s/test_must_fail has_cr/! has_cr/

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2019 at 7:02 AM Denton Liu <liu.denton@xxxxxxxxx> wrote:
> t0020: s/test_must_fail has_cr/! has_cr/

Cryptic patch subject. How about being consistent with other patch
subjects in this series?

    t0020: don't use `test_must_fail has_cr`

> The test_must_fail function should only be used for git commands since
> we should assume that external commands work sanely. Since has_cr() just
> wraps a tr and grep pipeline, replace `test_must_fail has_cr` with
> `! has_cr`.
>
> Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx>



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux