On Fri, Dec 13, 2019 at 01:18:44PM -0800, Junio C Hamano wrote: > Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes: > > > To help pinpoint the source of a regression, it is useful to know the > > version of libc which the user's Git client was built with. Let's > > include it alongside the other versioning information, which is used to > > identify how the client was built. > > > > Signed-off-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx> > > --- > > bugreport.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > This is the first iffy one in the series. It is unreasonable to > assume that we can dictate that Git can be built only on glibc > systems, no? > > Making this conditional, perhaps make "bugreport.c" depend on > "extern void get_compiler_info(struct strbuf *sys_info)" and require > the function to be defined in compat/; the glibc variant that uses > gnu_get_libc_version() would become just one of them. Interesting. This sounds like a good approach - thanks, I'll look into it. - Emily
