On 12/15/2019 3:30 PM, Johannes Schindelin wrote:
Hi Junio,
On Fri, 13 Dec 2019, Junio C Hamano wrote:
Denton Liu <liu.denton@xxxxxxxxx> writes:
@@ -4170,3 +4175,4 @@ def main():
if __name__ == '__main__':
main()
+
Spurious trailing line. Perhaps we could make GGG error out on
whitespace errors before submissions are allowed?
I think you are asking the tool for too much support.
It may help a lot more if we gave a Makefile target (or two) that
the contributors can run before going public. Perhaps
O=origin/master
upstream-check::
git log -p --check $(O)..
that can be used like so:
$ make upstream-check
$ make O=gitster/next upstream-check
That way, those who use format-patch+email without GGG or those who
push to a shared repository to be reviewed among the peer developers
before going public would benefit, not just GGG users.
Hmm?
I'd like that a lot, _and_ I think GitGitGadget could learn the trick of
running that `Makefile` target and report failures back to the PR
_especially_ because GitGitGadget knows the base branch of the PR.
In my opinion, there is a lot of value in having GitGitGadget doing this,
as new contributors are likely to miss such a helpful `Makefile` target.
For example, I vividly remember when I contributed to cURL for the first
time and had totally and completely missed the invocation `make -C src
checksrc` to help me get the code into the preferred shape.
Ciao,
Dscho
Same here for me. My entry point into submissions was through GGG. The
more suggestions it can offer prior to "/submit"ting code the easier it
would have been for me and the less noise I would have brought to the
mailing list.
- Ben
