On Fri, 13 Dec 2019 at 14:24, Johannes Sixt <j6t@xxxxxxxx> wrote: > > Am 13.12.19 um 18:55 schrieb Ed Maste: > > The regex failed to compile on FreeBSD. > > > > Fixes: a807200f67588f6e > > Having a references is this form is unusual for our codebase. (Not that > I mind a lot, though.) I expect that Junio will commit the fix on top of > the commit that introduced the bogus regex anyway (branch > ln/userdiff-elixir), and then it will be easy find. Ok, I picked this up from the Linux kernel where someone added a Fixes: tag to one of my changes (which had the hash of the original change as part of the commit message body). > > Signed-off-by: Ed Maste <emaste@xxxxxxxxxxx> > > --- > > Add /* -- */ to make things more clear and be consistent with other > > patterns. > > This text would be nice to have in the commit message. Ah, I didn't think it was remarkable (it's consistent with all of the existing entries) but the change is indeed broader than what the commit message implies. I'm happy to send a v3 with an amended commit message if that's desired.
