On Wed, Dec 11, 2019 at 03:38:20PM -0800, Emily Shaffer wrote:
> If a user is interacting with their config files primarily by the 'git
> config' command, using the location flags (--global, --system, etc) then
> they may be more interested to see the scope of the config file they are
> editing, rather than the filepath.
I don't mind adding this in, but I think we did discuss this same
concept when we did "config --show-origin", and ended up showing the
whole path, to help with a few cases:
- you know you're getting a value from the "system" config, but you
don't know where that is (e.g., because the baked-in sysconfdir path
is something you didn't expect)
- you're in a scope like "global", but the value actually comes from
an included file
Of course there's a flip-side, which is that showing "/etc/gitconfig"
doesn't tell you that this is the "--system" file; the user has to infer
that themselves.
There are no callers added here, so I'm not sure exactly how the new
function is meant to be used. But I'd caution that it might be worth
showing the scope _and_ the path, instead of one or the other.
-Peff
