Derrick Stolee <stolee@xxxxxxxxx> writes: > On 12/9/2019 6:52 AM, SZEDER Gábor wrote: >> 'git name-rev' is implemented using a recursive algorithm, and, >> consequently, it can segfault in deep histories (e.g. WebKit), and >> thanks to a test case demonstrating this limitation every test run >> results in a dmesg entry logging the segfaulting git process. >> >> This patch series eliminates the recursion. >> >> Changes since v2: >> >> - Add the new patch 12 to use 'name->tip_name' instead of >> 'tip_name', to make the patch eliminating the recursion a bit even >> easier to follow (only with '--ignore-all-space', though, without >> that option that patch's diff is still mostly gibberish). >> The end result is the still same, see the empty interdiff. > > This new commit makes sense, and I see how it adjusts the context lines > in the patch that follows. This series looks good to me. I've finished eyeballing the patches myself, and they seem to be in a good shape, too. Thanks.
