Alexandr Miloslavskiy <alexandr.miloslavskiy@xxxxxxxxxxx> writes: > and I can continue to extend it in the same direction, or try to > refactor to make it better. I actually choose the second path: > [1][2]. These were two "don't" lessons for me, as both topics now > gather dust in mail graveyard. If nobody commented on your patches, that is not a punishment. It could have been that reviewers were busy addressing other issues back then, in which case a gentle ping by resending a polished version (it could be that the changes were not presented well to attract reviewers' attention---polishing the proposed log messages without changing the patch text might be all it takes to make them realize that the topic is worth looking at) would help. > [1] > https://public-inbox.org/git/pull.479.git.1574969538.gitgitgadget@xxxxxxxxx/ > [2] > https://public-inbox.org/git/pull.477.git.1574848137.gitgitgadget@xxxxxxxxx/T/#u I actually was meaning to read and comment on [1], but lack of time pushed it down in my queue. Sorry about that.
