"Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> +test_clear_watchman () {
> + if test -n "$GIT_TEST_FSMONITOR"
> + then
> + watchman watch-list |
> + grep "$TRASH_DIRECTORY" |
> + sed "s/\",//g" |
> + sed "s/\"//g" >repo-list
Whoa, this is scary. "$TRASH_DIRECTORY" comes from $(pwd) and the
leading part of it can have arbitrary garbage like "[a-z]*" that may
match paths "watchman watch-list" may emit that does not have
anything to do with the temporary directory used by this test.
What are these stripping of ", and " about? Could you tell readers
how a typical output from the program we are reading from looks like
perhaps in the log message or in-code comment around here?
Thanks.
