On Mon, Dec 9, 2019 at 5:10 AM Denton Liu <liu.denton@xxxxxxxxx> wrote: > > In this email[1], Elijah pointed out that the handling of multiple > `format.notes` configurations could be buggy. If we had > `format.notes = <ref1>`, `format.notes = false` and > `format.notes = <ref2>`, the behaviour is ambiguous. This series uses > the way `--notes=<ref1> --no-notes --notes=<ref2>` is handled as a model > and structures the handling of `format.notes` in a similar manner, > allowing one `format.notes = false` to override previous configs. > > Also, in the same email, it was pointed out that git_config() should be > called before repo_init_revisions(). In 13cdf78094 (format-patch: teach > format.notes config option, 2019-05-16), the order was reversed. This > series changes it back such that git_config() is called before > repo_init_revisions(). Sweet, thanks for working on this. I took a very cursory glance over the patches and didn't spot anything egregiously wrong, though I'm also not familiar with the notes machinery. Mostly I'm just piping up to thank you for tackling this so quickly. :-)
