From: Jeff King <peff@xxxxxxxx> Some variables assignments in gitweb_run() look like this: FOO=""$1"" The extra quotes aren't doing anything. Each set opens and closes an empty string, and $1 is actually outside of any double-quotes (which is OK, because variable assignment does not do whitespace splitting on the expanded value). Let's drop them, as they're simply confusing. Signed-off-by: Jeff King <peff@xxxxxxxx> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> --- t/gitweb-lib.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh index 1f32ca66ea..b8455d1182 100644 --- a/t/gitweb-lib.sh +++ b/t/gitweb-lib.sh @@ -60,7 +60,10 @@ gitweb_run () { REQUEST_METHOD='GET' QUERY_STRING=$1 PATH_INFO=$2 +<<<<<<< HEAD REQUEST_URI=/gitweb.cgi$PATH_INFO +======= +>>>>>>> t/gitweb-lib.sh: drop confusing quotes export GATEWAY_INTERFACE HTTP_ACCEPT REQUEST_METHOD \ QUERY_STRING PATH_INFO REQUEST_URI -- gitgitgadget