On 12/7/2019 2:29 AM, Yang Zhao wrote:
On Fri, Dec 6, 2019 at 5:09 PM Denton Liu <liu.denton@xxxxxxxxx> wrote:
On Fri, Dec 06, 2019 at 04:33:18PM -0800, Yang Zhao wrote:
This patchset adds python3 compatibility to git-p4.
...
Currently, there's a competing effort to do the same thing[1] by Ben
Keene (CC'd). Like the last time[2] two competing topics arose at the
same time, I'm going to make the same suggestion.
Would it be possible for both of you to join forces?
Yes, I do believe we are aware of each other's efforts. I had submitted
an RFC patch set around the time Ben was preparing his own patchset.
I have not reviewed Ben's first patchset as I did not feel that I understood
the systems well enough at the time. I've briefly skimmed through Ben's latest
iteration and it would appear the general approach is very similar, but there's
more added abstractions and just general code change in his version.
Regardless, I'm open to working together.
I am also open to working together, and could really use the help, as I'm
not a python developer.
I have taken all the suggestions from my first patch set and have reworked
my code and commits and will submit them now for review. With the smaller
patches and cleaner commit messages I hope that it will make it easier
to see what I've done so far and what is still open work.
Ideally, I would prefer we land something minimal and working in mainline soon,
then further collaborate on changes that clean up code and enable more features.
My end-game is to have P4 Streams working in git-p4, and maybe LFS-like support
that uses p4 as the backend. It would be great to not be the only one
spending effort
in that direction.
Yang
I have similar goals. I would love to get the smallest set of non-breaking
changes in that allows the program to basically work with Python 3.5+.
My rush has been because I need to use git-p4 for work and have been
working
on the project at the office. Once I reach a point where I am able to
generally work (when t9800 is complete) I'll really not be free to spend
too
much work time on the project, but I am eager to see this through!
As far as status, the last time I ran tests, python 2.7 passed all the tests
and Python 3.5 passed some of the tests. I know it is not passing t9801
at this time and I'm trying to find out why.
So, Yang, I am very interested in working together.
Kindest regards,
Ben Keene
