Re: What's cooking in git.git (Dec 2019, #01; Mon, 2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Denton Liu <liu.denton@xxxxxxxxx> writes:

> vague commit messages from the first round of review. Note that 4/5 has
> a spurious change that should be removed ...

Which was exactly why I did not pick up the last posted one.  In
general, I would not pick up a series when the author is aware of an
issue to be fixed, and more importantly, when the author knows how
to fix that issue.  That way, I do not have to be as intimate with
the issue-and-fix as the author and the reviewer, who came up with
it in their exchange.  That way we can avoid unnecessary mistakes,
trying pick up the latest one and making an incorrect tweak that is
different from what the author and the reviewer agreed to be the
good way forward.

It's a different story when that reviewer is me, of course---in that
corner case, I should be just as familiar with the final issue as
the author would be, so it may save time without risking mixups for
me to add the final finishing touches myself.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux