Todd Zullinger <tmz@xxxxxxxxx> writes: > After Andreas' missing redirect fix, that still fails on > s390x (not surprisingly). But now systems with JIT enabled > fail at: > ... > Here's how I changed the commit message locally. I was > going to wait a day or so for any other feedback on the > actual test changes, being a holiday weekend in the US (and > more generally a weekend). > > 1: d9aeaf0c98 ! 1: d0c083db78 t7812: expect failure for grep -i with invalid UTF-8 data > @@ Commit message > 8a5999838e (grep: stess test PCRE v2 on invalid UTF-8 data, 2019-07-26) > and 870eea8166 (grep: do not enter PCRE2_UTF mode on fixed matching, > 2019-07-26) they lacked a redirect which caused them to falsely succeed > - on most architectures. They failed on big-endian arches where the test > - never reached the portion which was missing the redirect. > + on most systems. The 'grep -i' test failed on systems where JIT was > + disabled as it never reached the portion which was missing the redirect. > > - A recent patch add the missing redirect and exposed the fact that the > - 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' test fails on > - all architectures. > + A recent patch added the missing redirect and exposed the fact that the > + 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' test fails > + regardless of whether JIT is enabled. > > Based on the final paragraph in in 870eea8166: > > Thanks for pointing out the proper reasoning to use in the > commit message Andreas. I hadn't looked at the Fedora pcre2 > package to see that it explicitly disables JIT on s390x. OK. I locally edited the log message to match the above. I guess this forms an integral part of a topic that Andreas started with the "missing redirects" fix, so let me queue your patch directly on the same topic branch, without creating a separate one. Thanks, both.
