On Nov 30 2019, Johannes Sixt wrote: > Am 30.11.19 um 19:04 schrieb Junio C Hamano: >> "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> >> writes: >> >>> * We now assign errno only when the call to CreateProcessW() failed. >> >> Meaning the global variable 'errno' is left as it was (instead of >> getting cleared) when a system call succeeds? That I think is the >> correct behaviour people who use the variable expect. > > I hope you mean people who read the code. You cannot possibly mean > developers who expect that the run-command API keeps errno unchanged if > the calls were successful. I'm pretty sure they do not provide such a > guarantee. POSIX guarantees that no library function sets errno to zero. Andreas. -- Andreas Schwab, schwab@xxxxxxxxxxxxxx GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."
