> if (create_or_update_name(parent, new_name, taggerdate, > - new_generation, new_distance, > + generation, distance, > from_tag)) > - name_rev(parent, new_name, taggerdate, > - new_generation, new_distance, from_tag); > + name_rev(parent, new_name, taggerdate, from_tag); > } > } [snip] > if (create_or_update_name(commit, tip_name, taggerdate, > 0, 0, from_tag)) > - name_rev(commit, tip_name, taggerdate, 0, 0, > + name_rev(commit, tip_name, taggerdate, > from_tag); > else > free(to_free); All invocations of name_rev() are first preceded by create_or_update_name(), which sets the "generation" and "distance" fields in the name accordingly, so this looks good. All preceding patches look good too. I have already sent emails for patch 12 and 13, so this concludes my review.
