On Tue, Nov 26, 2019 at 9:09 PM Denton Liu <liu.denton@xxxxxxxxx> wrote: > Ever since bb52995f3e (format-patch: introduce format.useAutoBase > configuration, 2016-04-26), `git rebase` has been broken when > `format.useAutoBase = true`. Demonstrate that failure here. What specifically does "broken" mean here? > Reported-by: Christian Biesinger <cbiesinger@xxxxxxxxxx> > Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx> > --- > diff --git a/t/t3400-rebase.sh b/t/t3400-rebase.sh > @@ -159,6 +159,12 @@ test_expect_success 'fail when upstream arg is missing and not configured' ' > +test_expect_failure 'rebase works with format.useAutoBase' ' > + test_config format.useAutoBase true && > + git checkout topic && > + git rebase master > +' Having read both the commit message and the test itself, I'm not wiser about what is actually "broken" or what this is demonstrating.