On Fri, Nov 22, 2019 at 02:14:37PM +0100, SZEDER Gábor wrote: > The GIT_TEST_CLONE_2GB environment variable is only ever checked with > 'test -z' in 't5608-clone-2gb.sh', so any non-empty value is > interpreted as "yes, run these expensive tests", even > 'GIT_TEST_CLONE_2GB=NoThanks'. > > Similar GIT_TEST_* environment variables have already been turned into > bools in 3b072c577b (tests: replace test_tristate with "git > env--helper", 2019-06-21), so let's turn GIT_TEST_CLONE_2GB into a > bool as well, to follow suit. > > Our CI builds set GIT_TEST_CLONE_2GB=YesPlease, so adjust them > accordingly, thus removing the last 'YesPlease' from our CI scripts. This might break the setup of some developer or tester who put a similar value into their config.mak. But I think that's worth it to reduce confusion in the long run, especially since they will get a very clear error message due to your first patch. -Peff
