Re: [PATCH v3 1/1] submodule: fix 'submodule status' when called from a subdirectory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Manish Goregaokar via GitGitGadget" <gitgitgadget@xxxxxxxxx>
writes:

> +		test_cmp ../expect ../actual &&

Note that "test_cmp expect actual" highlights a breakage, when it
finds one, by showing a diff that shows "what we saw is different
from what we expected to see in this way".  So this invocation is
good.

> +		git -C ../submod checkout HEAD^ &&
> +		git submodule status >../output &&
> +		awk "{print \$1}" <../output >../actual2 &&
> +		cd .. &&
> +		git submodule status >output &&
> +		awk "{print \$1}" <output >expect2 &&
> +		test_cmp actual2 expect2 &&

But this one is probably the other way around.  I'll fix this up
while queuing, so if there is no other changes necessary, there is
no need to resend the patch.

> +		! test_cmp actual actual2

And the order of this one actually does not matter ;-)

> +	)
> +'

Thanks.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux