Not doing so can lead to wrong topo-walks when using the revision walk API consecutively. Signed-off-by: Mike Hommey <mh@xxxxxxxxxxxx> --- revision.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) As mentioned in 20191108025007.bphr7ynvskeoe6tb@xxxxxxxxxxxx, it feels like maybe TOPO_WALK_EXPLORED and TOPO_WALK_INDEGREE should be in ALL_REV_FLAGS too? diff --git a/revision.c b/revision.c index 0e39b2b8a5..765a56ae33 100644 --- a/revision.c +++ b/revision.c @@ -3098,7 +3098,7 @@ static void set_children(struct rev_info *revs) void reset_revision_walk(void) { - clear_object_flags(SEEN | ADDED | SHOWN); + clear_object_flags(SEEN | ADDED | SHOWN | TOPO_WALK_EXPLORED | TOPO_WALK_INDEGREE); } static int mark_uninteresting(const struct object_id *oid, -- 2.24.0.dirty