Christian Stimming <stimming@xxxxxxx> wrote: > Fix translation of strings in foreach lists. > > Signed-off-by: Christian Stimming <stimming@xxxxxxx> > --- > Quoting Brett Schwarz <brett_schwarz@xxxxxxxxx>: > >I not sure if it's worth changing, but you don't necessarily need > >those [append]'s in there. > > Thanks for the info. It is basically up to Shawn to decide which style > he likes more. "[mc Foo]\n\n$err" is much shorter. So I'd prefer that over [append [mc Foo] "\n\n$err"]. Its not like you've saved a dq-eval either, as you still have to do one for the \n\n. But either way is valid Tcl, and works, and the append version is not so bad that I'd reject a patch that used it. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html