Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: >> > * ag/sequencer-todo-updates (2019-10-28) 6 commits >> > - SQUASH??? tentative leakfix >> > - sequencer: directly call pick_commits() from complete_action() >> > - rebase: fill `squash_onto' in get_replay_opts() >> > - sequencer: move the code writing total_nr on the disk to a new function >> > - sequencer: update `done_nr' when skipping commands in a todo list >> > - sequencer: update `total_nr' when adding an item to a todo list >> > >> > Reduce unnecessary reading of state variables back from the disk >> > during sequener operation. >> > >> > Is the leakfix patch at the tip the only thing that needs to >> > prepare the topic ready for 'next'? >> > >> >> Yes, it is. > > I took a look at this. Some comments: I took a look at your comments and re-read the patches and I do agree with many of your points. Let me not merge this round to 'next' and wait for a reroll. Thanks for stopping me.