Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > Hans Jerry Illikainen wrote: > >> As part of implementing signature verification for git clone, I decided >> to refactor/unify the code for commit and merge verification to make it >> reusable during clones. > > Thanks for writing this. > > Most of the text in this cover letter would be useful to have in the > commit message. From the commit message alone, I could see that you > were fixing a bug, but I could not see the motivation or workflow it > is part of. If I were to later discover an issue triggered by this > commit, I wouldn't have enough information to weigh tradeoffs about > the right way to address such an issue. After reading the proposed log message of [PATCH v1 1/1], I have to disagree. It does not matter if we will later see new code in the clone codepath that would use the gpg-interface API. Whether it happens or not, this change to look for the key fingerprint only on the same line is something we should consider independently. On the other hand, why the author of this change thought that it may be necessary thing to do is an excellent material to tell the story behind the patch in the cover letter. Thanks.
