Re: [PATCH] git log -g: Complain, but do not fail, when no reflogs are there

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, 24 Jul 2007, Alex Riesen wrote:

> On 7/24/07, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
> > On Tue, 24 Jul 2007, Alex Riesen wrote:
> > > On 7/24/07, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
> > > >
> > > > When asking "git log -g --all", clearly you want to see only those refs
> > > > that do have reflogs, but you do not want it to fail, either.
> > > >
> > > > So instead of die()ing, complain about it, but move on to the other
> > refs.
> > > >
> > >
> > > I believe you wont even see these complaints: the pager will start shortly
> > > afterwards and fill the screen with commits, completely hiding the errors.
> > 
> > You can see it briefly, but it is hidden by default.  Which is a good
> > thing.  If you set the pager to "cat" (which is happily not the default!)
> > you can see them clearly.  Until you are swamped by the rest of the
> > output.
> > 
> > Maybe this is a feature?
> > 
> 
> Maybe. I can't see it at all. Should I downgrade something or propose
> a patch to put some delay after this error? I think not.
> 
> I think second Junios suggestion, but this is of course no
> difference to me.

Okay, two votes are enough to make me reconsider.  Junio, could you please 
replace the two "error(...)"s by "-1"s?  Only if you apply the patch, of 
course...

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux