On Thu, 14 Nov 2019 at 02:25, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > "Ben Keene via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > > > commit: git-p4.py: Cast byte strings to unicode strings in python3 > > Luke, this patch [*1*] came in my way, but I am hardly an expert on > Py2to3 and know nothing about P4. Could you take a look at them, > please? > > Thanks. > > > [References] > > <0bca930ff82623bbef172b4cb6c36ef8e5c46098.1573679258.git.gitgitgadget@xxxxxxxxx> I just quickly tried it, and with git-p4 switched to using python3, the unit tests fail. $ make -C t T=t98* But it looks like a reasonable approach, and with the demise of Python2 fast approaching it would be good to get this fully working! Luke
