On Thu, Nov 14, 2019 at 07:54:35AM +0100, Martin Ågren wrote: > > > The last patch is not meant for immediate inclusion, but I post it > > > anyway. I can re-submit it at an appropriate time, or maybe it could > > > slumber on pu until the time is ripe for completing the switch. > > > > I think bailing on values that can't be converted is normal for other > > code paths. E.g., just trying to print: > > > > $ git -c foo.bar=abc config --type=bool foo.abr > > fatal: bad numeric config value 'abc' for 'foo.bar': invalid unit > > I'm not sure if you mean "... so we could be a lot more aggressive > here"? Yeah, I think it's OK to be aggressive with bailing when the user gave us a --type, but the value doesn't match it. > I'm running now and I feel like I'll need to read your mail again > tonight and get back to you in more detail. Sure, no rush and thanks for working on it. :) -Peff
