"Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > The very real downside of the approach we have to take here is that the > test suite won't pass with `GIT_TEST_ADD_I_USE_BUILTIN=true` until the > conversion is complete (the `--helper` approach would have let it pass, > even at each of the incremental conversion steps). That actually is an issue of the quality of the tests you add for this series. If they are organized along the arc of run_add_i() gaining features, the invocation of "git add -i" in the tests can selectively use USE_BUILTIN=true to verify what has been rewritten so far. In any case, I think I've seen the patches in this part of the metaseries enough and I think they are quickly stabilizing. Let's see if others can find and raise issues and otherwise start cooking in 'next' sometime next week. Thanks.
